fix: check balances and revert after strategyRegistered

.github/workflows/foundry-gas-diff.yml

@@ -42,7 +42,7 @@ jobs:
           FOUNDRY_FUZZ_SEED: 0x${{ github.event.pull_request.base.sha || github.sha }}
 
       - name: Compare gas reports
-        uses: Rubilmax/foundry-gas-diff@v3.16
+        uses: Rubilmax/foundry-gas-diff@v3.21
         with:
           summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%)
           sortCriteria: avg,max # sort diff rows by criteria

foundry.toml

@@ -17,6 +17,7 @@
   via_ir = true
   src = "src"
   test = "test"
+  allow_internal_expect_revert = true
 
 [profile.ci]
   fuzz = { runs = 10_000 }

script/BaseDeploy.sol

@@ -71,6 +71,7 @@ contract BaseDeploy is CreateXScript {
         || block.chainid == 1_313_161_554 // Aurora
         || block.chainid == 196 // X Layer
         || block.chainid == 480 // Worldchain
+        || block.chainid == 146 // Sonic
     ) {
       return 0x0D946b7Fd00c9277c558710693076a592c2be27F;
     }

src/strategy-registry/EarnStrategyRegistry.sol

@@ -126,12 +126,13 @@ contract EarnStrategyRegistry is IEarnStrategyRegistry {
     // slither-disable-next-line reentrancy-no-eth
     bytes memory migrationResultData =
       oldStrategy.migrateToNewStrategy(proposedStrategyUpdate.newStrategy, migrationData);
+    proposedStrategyUpdate.newStrategy.strategyRegistered(strategyId, oldStrategy, migrationResultData);
+
     (address[] memory newStrategyTokens, uint256[] memory newStrategyBalances) =
       proposedStrategyUpdate.newStrategy.totalBalances();
     _revertIfNewStrategyBalancesAreLowerThanOldStrategyBalances(
       oldStrategyTokens, oldStrategyBalances, newStrategyTokens, newStrategyBalances
     );
-    proposedStrategyUpdate.newStrategy.strategyRegistered(strategyId, oldStrategy, migrationResultData);
   }
 
   function _revertIfNotStrategy(IEarnStrategy strategyToCheck) internal view {