Merged
Conversation
jleon15
commented
Nov 24, 2025
| } | ||
|
|
||
| private fun getJavaSdkEnvironment(environment: String?): Environment { | ||
| if (environment?.lowercase() == "test") Environment.TEST |
Contributor
Author
There was a problem hiding this comment.
this won't compile until we regenerate the java sdk
jleon15
commented
Nov 24, 2025
| private val apiUrl: String = "https://api.basistheory.com", | ||
| private val defaultApiKey: String? = null | ||
| private val defaultApiKey: String? = null, | ||
| private val environment: String? = "production" |
Contributor
Author
There was a problem hiding this comment.
We could make an ApiClientProviderV2 or something and only allow people to pass environment and api key, to remove api url if we wanted, though this is consistent with how it is on web elements.
dhudec
previously approved these changes
Dec 4, 2025
…o eng-9466-add-environment-option
dhudec
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist