Conversation
| } | ||
|
|
||
| print("[DEBUG executeTypedRequest] Headers: \(headers)") | ||
| print("[DEBUG executeTypedRequest] URL: \(url)") |
There was a problem hiding this comment.
This debug print logs all HTTP headers including API keys to stdout — remove before merging.
| let headers = getBasisTheoryHeaders(apiKey: getApiKey(apiKey), btTraceId: btTraceId) | ||
| let url = "\(basePath)/tokens/\(id)" | ||
|
|
||
| print("[DEBUG getTokenById] url: \(url)") |
There was a problem hiding this comment.
Debug print statement left in production code — remove before merging.
BasisTheoryElements/Sources/BasisTheoryElements/HttpClientHelpers.swift
Outdated
Show resolved
Hide resolved
BasisTheoryElements/Sources/BasisTheoryElements/BasisTheoryElements.swift
Outdated
Show resolved
Hide resolved
BasisTheoryElements/Sources/BasisTheoryElements/HttpClientHelpers.swift
Outdated
Show resolved
Hide resolved
BasisTheoryElements/Sources/BasisTheoryElements/BasisTheoryElements.swift
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| print("[DEBUG executeTypedRequest] FINAL URL: \(request.url!.absoluteString)") |
There was a problem hiding this comment.
This prints the full unmasked API key via request.allHTTPHeaderFields. The debugHeaders masking above is unused. Remove all debug prints before merging, or at minimum use debugHeaders instead.
| let headers = getBasisTheoryHeaders(apiKey: getApiKey(apiKey), btTraceId: btTraceId) | ||
| let url = "\(basePath)/tokens/\(id)" | ||
|
|
||
| print("[DEBUG getTokenById] url: \(url)") |
There was a problem hiding this comment.
Debug print left in production code — remove before merging.
|
|
||
| xcodebuild clean test \ | ||
| -project ./IntegrationTester/IntegrationTester.xcodeproj \ | ||
| -scheme IntegrationTester \ |
There was a problem hiding this comment.
-only-testing UnitTests/CardExpirationDateUITextFieldTests limits CI to a single test class, so UpdateTokenTests and all other tests won't run in CI.
| metadata: self.metadata, | ||
| searchIndexes: self.searchIndexes, | ||
| fingerprintExpression: self.fingerprintExpression, | ||
| mask: AnyCodable(self.mask), |
There was a problem hiding this comment.
AnyCodable(self.mask) when self.mask is nil creates a non-nil AnyCodable wrapping nil, which serializes as "mask": null in the merge-patch JSON — this will clear the mask on the server. Use self.mask.map { AnyCodable($0) } instead so the field is omitted when not set.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist