Skip to content

fix: update CI to support iPhone 17 Pro and fix architecture ambiguity#98

Open
kevinperaza wants to merge 5 commits intomasterfrom
fix/ci-test-failures
Open

fix: update CI to support iPhone 17 Pro and fix architecture ambiguity#98
kevinperaza wants to merge 5 commits intomasterfrom
fix/ci-test-failures

Conversation

@kevinperaza
Copy link
Contributor

Summary

  • Add support for iPhone 17 Pro simulator in CI tests (with fallback to iPhone 16 Pro)
  • Fix device architecture ambiguity by explicitly specifying -arch arm64
  • Set ONLY_ACTIVE_ARCH=NO for consistent builds across architectures

Changes

Updated .github/scripts/integration-test.sh:

  1. Try iPhone 17 Pro simulator first, fall back to iPhone 16 Pro if not available
  2. Add explicit architecture flag to avoid build ambiguity errors
  3. Ensure all architectures are built properly

Test plan

  • CI tests pass with iPhone 17 Pro simulator
  • CI tests still work with iPhone 16 Pro fallback
  • No architecture ambiguity errors during build

🤖 Generated with Claude Code

- Try iPhone 17 Pro simulator first, fall back to iPhone 16 Pro
- Add explicit -arch arm64 flag to avoid architecture ambiguity
- Set ONLY_ACTIVE_ARCH=NO for consistent builds

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Pin AnyCodable to exact version instead of using range to ensure
consistent builds across environments.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…upport

The package(url:exact:) API requires PackageDescription 5.6 or later.
This resolves the CI build error where Swift 5.5 doesn't support the
exact: parameter used in the AnyCodable dependency declaration.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The -arch flag conflicts with the -destination parameter since the
destination already implies the architecture. Removing -arch arm64
resolves the "destination implies architecture" build error.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…biguity

Adding arch=arm64 to the destination string prevents xcodebuild from
warning about multiple matching destinations. Removed ONLY_ACTIVE_ARCH=NO
as it's no longer needed when the architecture is explicitly specified.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants