Eng-8294: Removing jose and creating JWE with Noble#17
Merged
washluis-alencar merged 10 commits intomasterfrom Jun 17, 2025
Merged
Eng-8294: Removing jose and creating JWE with Noble#17washluis-alencar merged 10 commits intomasterfrom
washluis-alencar merged 10 commits intomasterfrom
Conversation
…of jose. Jose is not compatible with react-native with X25519.
kevinperaza
reviewed
Jun 16, 2025
kevinperaza
reviewed
Jun 16, 2025
kevinperaza
reviewed
Jun 16, 2025
Contributor
kevinperaza
left a comment
kevinperaza
left a comment
There was a problem hiding this comment.
On another note, I think we should add some tests for these new modules regardless of the approach we take
# Conflicts: # src/utils/base64Url.ts # src/utils/jwe.ts
lcschy
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist