feat: remove quick-crypto dependency#23
Merged
washluis-alencar merged 3 commits intomasterfrom Jul 28, 2025
Merged
Conversation
washluis-alencar
changed the title
brigonzalez
approved these changes
Jul 28, 2025
kevinperaza
reviewed
Jul 28, 2025
Comment on lines
+30
to
+39
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const { getRandomValues } = require('react-native-get-random-values'); | ||
|
|
||
| // Create minimal crypto object - @noble libraries only need getRandomValues | ||
| const minimalCrypto: MinimalCrypto = { | ||
| getRandomValues: getRandomValues, | ||
| subtle: undefined, | ||
| }; | ||
|
|
||
| globalThis.crypto = minimalCrypto as typeof globalThis.crypto; |
Contributor
There was a problem hiding this comment.
The lib is already a polyfill so no need for all this, in theory you can just import it in the entrypoint of the lib:
https://www.npmjs.com/package/react-native-get-random-values#usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist