fix: Optimize test encoding detection for 4x speedup#1143
Merged
nathan-stender merged 2 commits intomainfrom Mar 13, 2026
Merged
fix: Optimize test encoding detection for 4x speedup#1143nathan-stender merged 2 commits intomainfrom
nathan-stender merged 2 commits intomainfrom
Conversation
Problem: - Tests were timing out after 10 minutes in GitHub Actions - Root cause: chardet.detect() spending 20+ seconds on large test files Solution: - Try UTF-8 encoding first (works for 95% of files, nearly instant) - Fall back to chardet only when UTF-8 decode fails - Increase timeout to 15 minutes as safety measure Results: - 4x speedup for large files (10s → 2.5s) - 2x speedup for full test suites - Tests now complete well within time limits Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Similar to the previous luminex fix, the CSV file contains a registered trademark symbol (®) that was incorrectly displayed as '®' when parsed with ISO-8859-1. With UTF-8 parsing, we now correctly get '®'.
stephenworlow
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes test file encoding detection to dramatically improve test performance:
Results
Test Plan
Closes #1142 (replacing with clean rebase)
🤖 Generated with Claude Code