Add CaseInsensitive JSONExtract variants #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjevans
changed the title
adikus
approved these changes
Jul 14, 2025
| SELECT JSONExtractArrayRawCaseInsensitive('{"Items": [1, 2, 3]}', 'ITEMS') = ['1', '2', '3'] | ||
| ``` | ||
|
|
||
| ### JSONExtractKeysAndValuesRawCaseInsensitive {#jsonextractkeysandvaluesrawcaseinsensitive} |
There was a problem hiding this comment.
Does it make a difference for these extract functions to be case insensitive as well?
Author
There was a problem hiding this comment.
I basically went for any JSONExtract function that accepted a path.
There was a problem hiding this comment.
Ah ok, somehow missed that this accepts a path as well 🙈
Author
|
Closed in favour of the Clickhouse upstream PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the case-insensitive JSONExtract variants makes it easier to search unstructured/loosely-structured data in a performant manner.
We can take advantage of the simdjson function
at_key_case_insensitive(internally it does an iteration over keys with a case-insensitive strncasecmp). Compatibility function added for rapidjson.This won't do full multi-byte-encoding-aware case-insensitive comparisons on JSON keys, but I'd add explicit UTF8 variants if those were really needed (not sure they're needed for JSON keys).
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Users can now do case-insensitive JSON key lookups using JSONExtractCaseInsensitive (and other variants of JSONExtract).
Documentation entry for user-facing changes