Merged
Conversation
Closed
…n abstract method
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
Author
|
@jkanche it would be great if you could take a look at this PR as it makes changes to the |
jkanche
approved these changes
Apr 4, 2025
Member
jkanche
left a comment
jkanche
left a comment
There was a problem hiding this comment.
look good to me.
This would be a separate issue, but we should have getters and setters to some of these accessors. Also need to spell them out image_sources etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
img_source()inSpatialExperimentclassimg_source()in each child class ofVirtualSpatialExperiment