Open
Conversation
Fixed case-sensitive image file names, producing duplicate files (on some file systems). While at it, renamed related files to keep things semantically together. Renamed: STOWAWAY → stowaway_diagram stowaway → singletx_diagram Stonewall → stonewall_diagram STONEWALL X2(3) → stonewallx2_diagram The problematic files are currently only used in 'graphics.md' and 'csimplications.md'. I edited them to match the new file names.
Contributor
Author
|
Is this project dead, @bitlevi, @BitcoinQnA? Or just no time to maintain because of other things? Would love to hear a short ping from you. ✌️ L |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi QnA!
Today I wanted to help out a bit, but then I noticed, I need to help out a bit. ;)
I became aware of some horrible file names, that may technically do work on webservers, but as soon as they hit an NTFS file system (of a collaborator, i.e. me, in this case), it gets ugly. We don't want that to happen for no-one. Also GitHub Desktop is confused, believing a file has changed completely, but instead it is "just" a duplicate file due to the case-sensitive naming.
Long story short: I provided a fixed for that – luckily, it was just one occurrence.
Bonus: While at it, I also renamed related files to keep things semantically together, to not lose track anymore.
I renamed:
STOWAWAY.png → stowaway_diagram.png
stowaway.png → singletx_diagram.png
Stonewall.png → stonewall_diagram.png
STONEWALL X2(3).png → stonewallx2_diagram.png
The problematic files are currently only used in
graphics.mdandcsimplications.md. I edited them also, to match the new file names.Hope you're okay with that, and can pull this little tech fix quickly.
Also a good reminder to not use horrible file names. ;) There are some more (in /assets/img/), but they do not cause harm.
L