-
Notifications
You must be signed in to change notification settings - Fork 25
Article Create An Escrow #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
screenshot has "relase" the funds in red.. can you remake the screenshot @Anna15170221 |
pages/learn/create-escrow.js
Outdated
| return ( | ||
| <> | ||
| <SEO | ||
| title={'How to create an escrow on ' + explorerName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add explorerName, it will be already added in the tittle by default.
so, keep it simple like: "How to create an escrow"
pages/learn/create-escrow.js
Outdated
| description="Step-by-step guide on how to create an escrow on XRPL or Xahau. Understand XRPL and Xahau escrows, their use cases." | ||
| noindex={network !== 'mainnet'} | ||
| image={{ file: '/images/pages/learn/create-escrow/cover', width: 1520, height: 855, allNetworks: true }} | ||
| canonical={serverUrl + '/create-escrow'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove canonical={serverUrl + '/create-escrow'}
we don't need that
pages/learn/create-escrow.js
Outdated
| } | ||
|
|
||
| export default function CreateEscrow() { | ||
| const serverUrl = ['mainnet', 'testnet', 'devnet'].includes(network) ? 'bithomp.com' : 'xahauexplorer.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this remove this
pages/learn/create-escrow.js
Outdated
| <figure> | ||
| <Image | ||
| src={'/images/pages/learn/create-escrow/cover' + (xahauNetwork ? '-xahau' : '') + '.jpg'} | ||
| alt="Create an escrow on XRPL and Xahau" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep it simple "Create an Escrow"
pages/learn/create-escrow.js
Outdated
| <figure> | ||
| <Image | ||
| src={'/images/pages/learn/create-escrow/screen' + (xahauNetwork ? '-xahau' : '') + '.png'} | ||
| alt="Create an escrow on XRPL and Xahau" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keept it simple, alts shoud be different preferably
pages/learn/create-escrow.js
Outdated
| <strong>Step 1. Enter the Recipient Address</strong> | ||
| </p> | ||
| <p>Fill in the destination wallet address.</p> | ||
| <p>👉 If the recipient is using an exchange or a service, you may also need to enter a Destination Tag.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advice not to use exchnage or services addresses, if exhange change address or exchnage will be shout down - they will never get their escrow
| <div className="flex justify-center"> | ||
| <figure> | ||
| <Image | ||
| src={'/images/pages/learn/create-escrow/cover' + (xahauNetwork ? '-xahau' : '') + '.jpg'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need two new screenshots, as the old one has an error in red text . release
ihomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please view the comments
All is fixes besides new screenshots.
No description provided.