Skip to content

Conversation

@noraj
Copy link
Contributor

@noraj noraj commented Dec 4, 2025

Revert #4723 as explained in #4723 (comment)

@noraj noraj requested a review from noptrix as a code owner December 4, 2025 21:35
@s7x
Copy link
Contributor

s7x commented Dec 4, 2025

We should add a disclaimer then if we revert this, just in case people start wondering why is nuclei not taking into account their config file located in ~/.config/nuclei/config.yaml. What do you think @noraj ?

@noraj
Copy link
Contributor Author

noraj commented Dec 4, 2025

@s7x The issue is nuclei only follows XDG Base Directory Specification ([AL]) partially. It only looks at ~/.config/nuclei/config.yaml and does not resolve $XDG_CONFIG_DIRS or $XDG_CONFIG_HOME, that would allow us to deploy the config at /etc/nuclei/config.yml globally for all user and then each user to override with their own ~/.config/nuclei/config.yaml if wanted.

Because XDG standard is not followed for data dir, we made a config wrapper that is now hurting the wall of the config dir because XDG standard is not followed here either. We could continue to add patches and wrappers, but it would be best that upstream follows XDG standard instead.

I have opened a discussion upstream: https://github.com/orgs/projectdiscovery/discussions/6658

@s7x
Copy link
Contributor

s7x commented Dec 4, 2025

@s7x The issue is nuclei only follows XDG Base Directory Specification ([AL]) partially. It only looks at ~/.config/nuclei/config.yaml and does not resolve $XDG_CONFIG_DIRS or $XDG_CONFIG_HOME, that would allow us to deploy the config at /etc/nuclei/config.yml globally for all user and then each user to override with their own ~/.config/nuclei/config.yaml if wanted.

Because XDG standard is not followed for data dir, we made a config wrapper that is now hurting the wall of the config dir because XDG standard is not followed here either. We could continue to add patches and wrappers, but it would be best that upstream follows XDG standard instead.

I have opened a discussion upstream: https://github.com/orgs/projectdiscovery/discussions/6658

I did not know they were not following the XDG entirely. Thanks for the insight & the PR/Issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants