-
-
Notifications
You must be signed in to change notification settings - Fork 621
Add evil-winrm-py #4804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add evil-winrm-py #4804
Conversation
|
The tool doesn't seem to bring much features compared to the original https://github.com/Hackplayers/evil-winrm. Upstream (rb evil-winrm) is still maintained, this project (py evil-winrm) is just a python port. It's (py) not easier to use or more accessible that way. However, it's true the original tool (rb) has a very bad architecture (2k LoC long one-file) which make it hard to contribute to it but easy to drop on a remote system. But anyway, that tool is still featureful and easy to use, I don't see interest into packaging a redundant tool doing exactly the same for end users. |
|
Thanks for the detailed feedback, that makes sense. I agree that from an end-user perspective the Ruby version already covers the use case very well and is still actively maintained, and I understand the concern about avoiding redundant tools in BlackArch. One motivation for this PR was that Ruby can sometimes be an obstacle for some users or environments, whereas Python can make the tool a bit more friendly and accessible in certain setups. That said, I agree this alone may not be a strong enough reason to justify packaging a redundant tool. No problem closing this PR if you feel it doesn’t fit the project’s scope. |
I may be true outside distro packaging systems, for people wanting to install tools manually, but that precisely one of the interests of distro packaging, either way, whatever the programming language is behind, the BlackArch user will install it with
I'll let the others decide. But thank you for your contribution anyway. |
|
I had some engagements recently where evil-winrm-py was the tool of choice, as evil-winrm behaved unstable and connections have been lost. unfortunately we hadn’t had enough time to investigate what caused the instability. |
|
@0xbbuddha meanwhile please check the |
done |
This PR adds evil-winrm-py, a Python implementation of a WinRM shell for Windows and Active Directory pentesting.
blackarchandblackarch-windowsmakepkgLet me know if any adjustments are needed.