Skip to content

NHEK (2)#21

Open
addruart wants to merge 22 commits intomasterfrom
NHEK
Open

NHEK (2)#21
addruart wants to merge 22 commits intomasterfrom
NHEK

Conversation

@addruart
Copy link
Copy Markdown
Collaborator

Functions providing the parametrizations and properties of Kerr near-horizon geodesics added.

@addruart
Copy link
Copy Markdown
Collaborator Author

@nielsw2, @duetosymmetry, where does this error comes from ? The file Kernel/NearHorizonGeoOrbit.m seems to work correctly on my MMA installation...

@nielsw2
Copy link
Copy Markdown
Member

nielsw2 commented Jul 15, 2020

I've now rewound the master branch. Please don't merge this NHEK (2) branch until we've had a chance to review it.

I'm not sure why the tests failed. I looked at the log and it seemed the tests were timing out. Might be an issue with the test server so we'll check that and get back to you.

@addruart
Copy link
Copy Markdown
Collaborator Author

Thanks, @nielsw2 ! I don't do anything until you ask me

@addruart
Copy link
Copy Markdown
Collaborator Author

Hi @nielsw2, @barrywardell ! Is there any news regarding the addition of our NHEK code to the main branch of KerrGeodesics ? Thanks for your answer !

@nielsw2
Copy link
Copy Markdown
Member

nielsw2 commented Sep 14, 2020

Hi @addruart, apologies for the delay. It's been a busy few months so I've not had time to look at all the great work that needs to be merged. I hope to have more time in the next couple of weeks and will be in touch then.

@addruart
Copy link
Copy Markdown
Collaborator Author

No problem @nielsw2 ! Thoses times are not simple for anyone... I'll be glad to hear from you soon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants