Updated eccentric equatorial separatrix to analytic result#58
Open
joshbmat wants to merge 1 commit intoBlackHolePerturbationToolkit:masterfrom
Open
Updated eccentric equatorial separatrix to analytic result#58joshbmat wants to merge 1 commit intoBlackHolePerturbationToolkit:masterfrom
joshbmat wants to merge 1 commit intoBlackHolePerturbationToolkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change.
Solved the quartic separatrix polynomial (equatorial plane case) with the analytic expression. Checked to be safe in all limits and compared with existing root finding method.
Now can return analytic expression for separatrix as functions of a,e,x=+/-1 instead of only numeric values from root finding method, can take series expansions etc.