MOB-47082 metrics and concurrency#1974
Closed
ilonablazemeter wants to merge 11 commits intomasterfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional support for the new Happysocks ClickHouse-backed namespace, wiring it through the BlazeMeter reporter configuration and validating behavior via unit tests.
Changes:
- Introduce
/v1/engine-chnamespace support viause_clickhouseinHappysocksClient/HappysocksEngineNamespace. - Expose
happysocks-use-clickhousesetting in the BlazeMeter reporter to toggle the ClickHouse namespace. - Add/extend unit tests and update changelog/changes entry documenting the feature.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
bzt/utils.py |
Adds ClickHouse namespace constant and propagates use_clickhouse to connect/emit namespaces. |
bzt/modules/blazemeter/blazemeter_reporter.py |
Reads happysocks-use-clickhouse and passes it to HappysocksClient. |
tests/unit/test_bza.py |
Adds coverage for ClickHouse namespace connect/emit and namespace selection behavior. |
tests/unit/modules/test_blazeMeterUploader.py |
Verifies reporter instantiates HappysocksClient with correct use_clickhouse argument. |
bzt/modules/console.py |
Updates urwid import paths (likely aligning with current urwid dependency layout). |
site/dat/docs/changes/feat-support-for-clickhouse-happysocks-namespace.change |
Adds the required one-line change note for the feature. |
site/dat/docs/Changelog.md |
Adds release notes for 1.16.50 describing the new namespace support and setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
==========================================
- Coverage 89.91% 89.86% -0.04%
==========================================
Files 71 71
Lines 20182 20183 +1
==========================================
- Hits 18145 18136 -9
- Misses 2037 2047 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each PR must conform to Developer's Guide.
Quick checklist:
site/dat/docs/changesdirectory, one-line note of change inside