scripts/definitions/pickups.as: check if a pickup was picked before#57
Open
l29ah wants to merge 1 commit intoBlindMindStudios:masterfrom
Open
scripts/definitions/pickups.as: check if a pickup was picked before#57l29ah wants to merge 1 commit intoBlindMindStudios:masterfrom
l29ah wants to merge 1 commit intoBlindMindStudios:masterfrom
Conversation
|
Hey! I reported this bug in 2017, Thanks for fixing it. |
DaloLorn
referenced
this pull request
in OpenSRProject/OpenStarRuler-Modpack
Aug 31, 2020
DaloLorn
suggested changes
Aug 31, 2020
Contributor
DaloLorn
left a comment
DaloLorn
left a comment
There was a problem hiding this comment.
I only just realized how horribly wrong this is... good thing I was rewriting it anyway. 😟
Your solution means that each pickup type can be collected once. The correct solution is to make each pickup object track whether it's been collected yet.
DaloLorn
added a commit
to OpenSRProject/OpenStarRuler-Modpack
that referenced
this pull request
Aug 31, 2020
DaloLorn
added a commit
to OpenSRProject/OpenStarRuler-Modpack
that referenced
this pull request
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #45