Added encrypted pin options#58
Open
OscillatingMonkey wants to merge 1 commit intoBlock-Equity:developmentfrom
Open
Added encrypted pin options#58OscillatingMonkey wants to merge 1 commit intoBlock-Equity:developmentfrom
OscillatingMonkey wants to merge 1 commit intoBlock-Equity:developmentfrom
Conversation
Summary This feature allows users refined control over the security of their wallet. There is an options screen that a user can select to gate payments, app launch, and mnemonic view. Pin change settings have also been moved to fall underneath the main app settings screen. Changes - Moved PIN functionality to separate module under db/pin. There is now model validation. All pin settings are encrypted. Pin sequence is now saved under sequence key within the pin object. - Added PIN options screen - Moved PIN change screen into PIN options screen - Added gating logic to mnemonic view and payment - Adjusted all areas using old user pin settings to use db/pin module TODO - Add launch screen PIN setting - Add data change to update module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This feature allows users refined control over the security of their
wallet. There is an options screen that a user can select to gate
payments, app launch, and mnemonic view. Pin change settings have also
been moved to fall underneath the main app settings screen.
Changes
model validation. All pin settings are encrypted. Pin sequence is now
saved under sequence key within the pin object.
TODO