-
Notifications
You must be signed in to change notification settings - Fork 94
Fix: Swapped buttons on TTGO & enable USB JTAG on Waveshare S3 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fix: Enable USB JTAG serial for Jade on WaveshareSet CONFIG_JADE_USE_USB_JTAG_SERIAL to 'y' in the Waveshare S3 touch LCD2 defaults to enable USB JTAG serial support for Jade on the ESP32S3 target. |
|
Hey @jgriffiths there's any plan to merge this? I have tested the changes made on the file |
|
Hi, I'm planning to include this in our next update yes - apologies for the delay. I'm hoping to be merging the initial changes for the next release next week. |
|
@CaTeIM can you rebase this PR to remove the merge commits when you get time? thanks! |
|
@jgriffiths rebase done! Just a heads up: I also included a fix to enable USB JTAG serial for Jade on Waveshare S3 in this PR. Let me know if you prefer this in a separate PR. Thanks! |
Set CONFIG_JADE_USE_USB_JTAG_SERIAL to 'y' in the Waveshare S3 touch LCD2 defaults to enable USB JTAG serial support for Jade on the ESP32S3 target.
|
@trevarj thanks for the feedback! I've updated the commit message for the TTGO fix to be more descriptive as suggested. If you strictly prefer the Waveshare fix in a separate PR, let me know and I can split them. Otherwise, I hope this cleaner history works for merging. |
This pull request fixes the swapped button configuration for BOARD_TYPE_TTGO_TDISPLAY and BOARD_TYPE_TTGO_TDISPLAYS3.
Previously, the pins assigned to buttons A and B were reversed, causing inverted navigation behavior on the firmware.