Skip to content

Conversation

@CaTeIM
Copy link

@CaTeIM CaTeIM commented Oct 20, 2025

This pull request fixes the swapped button configuration for BOARD_TYPE_TTGO_TDISPLAY and BOARD_TYPE_TTGO_TDISPLAYS3.
Previously, the pins assigned to buttons A and B were reversed, causing inverted navigation behavior on the firmware.

@CaTeIM
Copy link
Author

CaTeIM commented Nov 25, 2025

Fix: Enable USB JTAG serial for Jade on Waveshare

Set CONFIG_JADE_USE_USB_JTAG_SERIAL to 'y' in the Waveshare S3 touch LCD2 defaults to enable USB JTAG serial support for Jade on the ESP32S3 target.

@CaTeIM CaTeIM closed this Nov 25, 2025
@CaTeIM CaTeIM reopened this Nov 25, 2025
@notf0und
Copy link

Hey @jgriffiths there's any plan to merge this? I have tested the changes made on the file main/Kconfig.projbuild only and they fix the buttons for a BOARD_TYPE_TTGO_TDISPLAY device. Or maybe make available a config variable so we can optionally swap the navigation buttons? Thanks!

@jgriffiths
Copy link
Collaborator

Hi,

I'm planning to include this in our next update yes - apologies for the delay. I'm hoping to be merging the initial changes for the next release next week.

@jgriffiths
Copy link
Collaborator

@CaTeIM can you rebase this PR to remove the merge commits when you get time? thanks!

@CaTeIM CaTeIM changed the title Fix: Swapped buttons A/B on Jade DIY (TTGO T-Display & T-Display S3) Fix: Swapped buttons A/B on Jade DIY (TTGO T-Display & T-Display S3) & enable USB JTAG serial for Waveshare Nov 28, 2025
@CaTeIM CaTeIM changed the title Fix: Swapped buttons A/B on Jade DIY (TTGO T-Display & T-Display S3) & enable USB JTAG serial for Waveshare Fix: Swapped buttons on TTGO & enable USB JTAG on Waveshare S3 Nov 28, 2025
@CaTeIM
Copy link
Author

CaTeIM commented Nov 28, 2025

@jgriffiths rebase done!

Just a heads up: I also included a fix to enable USB JTAG serial for Jade on Waveshare S3 in this PR. Let me know if you prefer this in a separate PR. Thanks!

@trevarj
Copy link
Contributor

trevarj commented Nov 28, 2025

Waveshare commit closes #248.

I would've done this in a separate PR or give the TTGO commit (e51ba8c) a better message so it can be merged and have the history be clear

Set CONFIG_JADE_USE_USB_JTAG_SERIAL to 'y' in the Waveshare S3 touch LCD2 defaults to enable USB JTAG serial support for Jade on the ESP32S3 target.
@CaTeIM
Copy link
Author

CaTeIM commented Nov 28, 2025

@trevarj thanks for the feedback!

I've updated the commit message for the TTGO fix to be more descriptive as suggested.

If you strictly prefer the Waveshare fix in a separate PR, let me know and I can split them. Otherwise, I hope this cleaner history works for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants