Add "Install Server" button to VSCode extension#170
Add "Install Server" button to VSCode extension#170KyrylR merged 11 commits intoBlockstreamResearch:masterfrom
Conversation
|
I'm curious - how do other LSPs get installed and started? |
|
I checked, and it seems like popular languages install the language server automatically, while others, require separate installation. I was actually inspired by But yeah, we can launch this in the background and install the server without prompting the user. |
|
I like the idea of it being available to other editors. But if we can make it seamless to the end user on VSCode, I see no reason to not launch it automatically. |
imaginator
left a comment
imaginator
left a comment
There was a problem hiding this comment.
besides the line 60 let vs const, this looks good.
|
glad to hear it! |
|
For the context: Go to references is broken, pls take a look UPD: comment resolved |
previously, restarting the server after uninstalling `simplicityhl-lsp` caused an error, because the extension attempted to launch a missing executable. this change ensures that server is checking that this executable is present and install otherwise.
Installing the server via `cargo` overrides the local installation, even if it has a higher version. This is problematic if we want to test the LSP server inside VSCode, so now there option in settings to disable autoupdate.
Co-authored-by: Kyrylo Riabov <kyryl.ryabov@gmail.com>
|
ACK 237deb5 Installed and verified extension locally |
3 participants
fixes #169
This button appears if the user is missing the
simplicityhl-lspexecutable. It spawns thecargo install simplicityhl-lspand shows progress notification for compiling.This also updates the LSP installation method in the README and changes the
Learn morelink to point to this repository instead of the old one.