Fix Unnecessary Margin style.scss#53
Fix Unnecessary Margin style.scss#53apoelstra merged 1 commit intoBlockstreamResearch:masterfrom iajhff:master
Conversation
1 │.main-content {
2 │ padding: 0 37px;
3 │- margin: 220px auto 75px;
4 │+ margin: 40px auto 75px;
5 │ @media (max-width: 768px) {
6 │- margin-top: 75px;
7 │+ margin-top: 30px;
8 │ padding: 0 10px;
9 │ }
10 │}
|
I have no idea how to review this. Is the padding "unnecessary"? According to whom? Where does this padding appear? How does it display on different devices? Certainly, I need more justification than the word "unnecessary". |
|
Apologies, I will improve my commit messages thank you for your guidance If you visit: https://ide.simplicity-lang.org/ there is an extra margin-top for both max width and < 768px which takes up space between navigation and main-content which seems "unnecessary" Reduces margin-top for .main-content >768px to 40px, and <768px as defined by @media property for responsiveness to 30px (save 10px for smaller width). Existing live site: Applying to live version: Locally deployed with full cargo build using scss instead of browser edit: |
|
Oops, sorry, I had meant to ACK and merge this last week. Can you remove the new commit (see discussion in #54 -- I don't think it's correct)? |
|
OK, I've reverted my master so it's only the one file changed. Thanks hope that this works fine for you |
2 participants
1 │.main-content {
2 │ padding: 0 37px;
3 │- margin: 220px auto 75px;
4 │+ margin: 40px auto 75px;
5 │ @media (max-width: 768px) {
6 │- margin-top: 75px;
7 │+ margin-top: 30px;
8 │ padding: 0 10px;
9 │ }
10 │}