In Debugger mode watch files and refresh when they change#6242
Open
In Debugger mode watch files and refresh when they change#6242
Conversation
JohnThomson
approved these changes
Jan 5, 2024
Contributor
JohnThomson
left a comment
There was a problem hiding this comment.
LGTM. Some very minor suggestions, or you can just merge.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @hatton)
src/BloomExe/Edit/EditingModel.cs line 1783 at r1 (raw file):
if (CurrentBook == null) return; // if we've been called already in the past 5 seconds, don't do it again
2 seconds :-)
src/BloomExe/Edit/EditingModel.cs line 1798 at r1 (raw file):
// Enhance: I suspect all the problems here are related to us changing the page id's each time we load, which I don't understand. // It may just be a mistake. if (args.Name.EndsWith(".json"))
.ToLowerCaseInvariant() ?
src/BloomExe/web/controllers/BrandingSettings.cs line 180 at r1 (raw file):
{ NonFatalProblem.Report( ModalIf.Beta,
Do we want Alpha, or even do this at all only for developers? At least the message about watch:branding:files will only help devs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is