Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the BloomBrowserUI dependency on @sillsdev/config-r and updates the Book Settings dialog to match the newer Config-R page/group API.
Changes:
- Bump
@sillsdev/config-rfrom1.0.0-alpha.15to1.0.0-alpha.18(and updateyarn.lockaccordingly). - Remove the no-longer-needed
patch-packagepatch that adjusted@sillsdev/config-r’spackage.jsonexports. - Refactor
BookSettingsDialogto useConfigrPage/ConfigrGroup/ConfigrStaticand update the initial selection prop name.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BloomBrowserUI/yarn.lock | Locks @sillsdev/config-r to 1.0.0-alpha.18 with updated resolved/integrity metadata. |
| src/BloomBrowserUI/patches/@sillsdev+config-r+1.0.0-alpha.15.patch | Removes the patch previously required to fix Config-R exports. |
| src/BloomBrowserUI/package.json | Updates the declared @sillsdev/config-r dependency version. |
| src/BloomBrowserUI/bookEdit/bookSettings/BookSettingsDialog.tsx | Updates the dialog structure to Config-R’s newer page-based API and adjusts theming for the custom slider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
023f82b to
6c6f578
Compare
6c6f578 to
426e9b1
Compare
426e9b1 to
27aad28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is