Skip to content

Weather component#70

Open
Bryce-Soghigian wants to merge 11 commits intomasterfrom
WeatherComponent
Open

Weather component#70
Bryce-Soghigian wants to merge 11 commits intomasterfrom
WeatherComponent

Conversation

@Bryce-Soghigian
Copy link
Contributor

Description

Add attribution link to Readme and code

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Please describe steps taken to ensure this feature is functional and does not break other features:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if relevant
  • I have run the app using my feature and ensured that no functionality is broken
  • My changes generate no new warnings
  • There are no merge conflicts

@Bryce-Soghigian
Copy link
Contributor Author

At first Prettier may seem to make more of a mess of the codebase than it fixes, but I think adding this prettier config will lead to consistent code styling throughout our codebase!

I am rewriting the entire weather component due to the API that the previous team was using being depreciated.

I also added a loading spinner into utils so that we can use that throughout our application if need be.

let reverseGeocodeKey = "j5l5gEtlUQow2kzyIZmI0BvcAf4xo7By";
axios
.get(
`http://www.mapquestapi.com/geocoding/v1/reverse?key=${reverseGeocodeKey}&location=${latitude},${longitude}&includeRoadMetadata=true&includeNearestIntersection=true`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code takes our coords we get and feeds them to a reverse geocoding api to fetch the city location

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review May 28, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant