BUG: Fix two bugs in IdentifySampleSliceBySliceFunctor#1562
Open
imikejackson wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Open
BUG: Fix two bugs in IdentifySampleSliceBySliceFunctor#1562imikejackson wants to merge 1 commit intoBlueQuartzSoftware:developfrom
imikejackson wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Conversation
1. Fix incorrect global index in fill-holes setValue: the local plane
index was used directly instead of decomposing into p1/p2 and
applying the correct strides. This produced wrong results for XZ
and YZ planes.
2. Reset the checked vector before the fill-holes phase. Without the
reset, voxels visited during sample identification were skipped
during hole filling, leaving unfilled holes inside the sample.
Update IdentifySampleTest to use v2 test data with all 12 parameter
combinations (fill/nofill x whole/sliced x XY/XZ/YZ).
imikejackson
force-pushed
the
bug/identify_sample_indexing
branch
from
076dec4 to
53c5ed7
Compare
nyoungbq
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect global index in fill-holes setValue: the local plane index was used directly instead of decomposing into p1/p2 and applying the correct strides. This produced wrong results for XZ and YZ planes.
Reset the checked vector before the fill-holes phase. Without the reset, voxels visited during sample identification were skipped during hole filling, leaving unfilled holes inside the sample.
Update IdentifySampleTest to use v2 test data with all 12 parameter
combinations (fill/nofill x whole/sliced x XY/XZ/YZ).