Skip to content

Conversation

@MichaelOcampo1104
Copy link

Description

Added Table 5.2 Part subject to bending and compression with test

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • [-] I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • [-] New and existing unit tests pass locally with my changes

add new table for ec3 chapter 5
added new table for EC3 chapter 5
added test for table_5_2_sht1_part_bendcomp.py
Updated test ready for pull request
@MichaelOcampo1104 MichaelOcampo1104 deleted the ec3addformula branch October 9, 2025 07:37
@MichaelOcampo1104 MichaelOcampo1104 restored the ec3addformula branch October 9, 2025 07:40
@egarciamendez
Copy link
Member

@MichaelOcampo1104 welcome to Blueprints! Thank you for your contribution! I will have a look to it asap

@SZeltaat SZeltaat self-requested a review October 13, 2025 06:11
@SZeltaat
Copy link
Contributor

Hi @MichaelOcampo1104,
Thank you for contributing to Blueprints!

Enevthough the implementation of tables is not standardized within Blueprints, it has some considerations. We generally allow subclassing from Formula if it fits the purpose. In case of Table 5.2, I don't think it is the appropriate choice. Since Table 5.2 is rather complex, we need to come up with a propper structure for it to facilitate all the possible use-cases and cover all the information provided in the code. And above all, provide a clear and intuitive API for our users.

I have opened issue #792. Please feel free to discuss your ideas on what architecture you would choose for the implementation. Once we have consensus, you can assign it to yourself and start working on the PR.

For inspiration, you can have a look at the tables implemented in chapter 4 of EN1992-1-1.

Best of luck! 🚀

@GerjanDorgelo
Copy link
Contributor

i kinda like the approach that has been used in this PR. when looking at the table.. its not really a table, its just formatted as is. Basically table 5.1 part 1 is just 3 (series of) equations using c, t, alpha and fy as input variables, one of which is featured in this PR. It would need clarification that it only does the Internal compression parts though, and im not sure where the current equations for alpha and psi come from

@MichaelOcampo1104
Copy link
Author

@GerjanDorgelo , Yes, the way I approach Table 5.2 Sheet 1/3 is provide it with 3 equation instead of a formal table., this approach can apply similarly for Sheet 2 and 3, as for the alpha and psi , these values are derived from the equilibrium of stress distribution as illustrated in Table 5.2 Sheet1/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants