-
Notifications
You must be signed in to change notification settings - Fork 17
677 feature request add steel shapes for c profiles #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
677 feature request add steel shapes for c profiles #825
Conversation
…ns and enhance geometry calculations
…ection to include additional slope parameters
…erties, improve parameter descriptions, and update example usage
…ate geometry calculations
…utes and plotting functionality
…pdate toe radius handling for better geometry accuracy
… update example usage for top flange cross-section
…mpossible geometry with maximum corrosion
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for C-profile steel sections (specifically UNP profiles) by enhancing the CircularCorneredCrossSection class to handle non-90 degree angles. The implementation introduces slope parameters for inner and outer arcs at both vertical and horizontal sections, enabling accurate modeling of tapered flanges common in UNP profiles.
Key changes:
- Added
slope_to_angleandangle_to_slopehelper functions for converting between slope percentages and angles - Extended
CircularCorneredCrossSectionwith slope parameters and reference point options - Implemented
UNPSteelProfileclass with support for standard profiles and corrosion modeling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| blueprints/math_helpers.py | Added conversion functions between slope percentages and angles |
| blueprints/structural_sections/cross_section_cornered.py | Enhanced to support non-90 degree corners with slope parameters |
| blueprints/structural_sections/steel/steel_cross_sections/unp_profile.py | New UNP profile implementation using enhanced cornered sections |
| tests/test_math_helpers.py | Added tests for slope/angle conversion functions |
| tests/structural_sections/test_cross_section_cornered.py | Updated tests to cover new slope parameters |
| tests/structural_sections/steel/steel_cross_sections/test_unp_profile.py | Comprehensive tests for UNP profile functionality |
| tests/structural_sections/steel/steel_cross_sections/conftest.py | Added fixture for UNP profile testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blueprints/structural_sections/steel/steel_cross_sections/unp_profile.py
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 393 394 +1
Lines 12106 12220 +114
==========================================
+ Hits 12106 12220 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…l thickness assignment in UNPSteelProfile
…ttps://github.com/Blueprints-org/blueprints into 677-feature-request-add-steel-shapes-for-c-profiles
…rneredCrossSection
…for clarity and efficiency
…dd extension calculation test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blueprints/structural_sections/steel/steel_cross_sections/unp_profile.py
Outdated
Show resolved
Hide resolved
|
Hi @GerjanDorgelo, Welcome back! 😃 And please 😭 No large PR's! 😅 |
…rove logic and handle corrosion effects on arc points
…for outer radius in flange calculations
…ion and corresponding test
|
@SZeltaat yess correct! if your code is indeed ready soon, i propose merging that one first into the main and then me ammending this PR. and yes now that i know my approach works, ill split this one into two maybe three PRs (once i know what edits it needs to accomodate your changes) |
|
@GerjanDorgelo I'll do my best to get it into main as fast as possible. I'm almost there 😉 |
Description
These additions will need patchy when Sina his code reaches main branch.
Fixes #677
Type of change
Checklist: