Skip to content

Conversation

@GerjanDorgelo
Copy link
Contributor

@GerjanDorgelo GerjanDorgelo commented Nov 16, 2025

Description

  • extended logic behind cornered sections such that it allows non-90 degree angles.
  • added two new math helpers, to convert slope to and from angles
  • these are then used to build a UNP using logic as is used in rest of project currently.

These additions will need patchy when Sina his code reaches main branch.

Fixes #677

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

…ection to include additional slope parameters
…erties, improve parameter descriptions, and update example usage
…pdate toe radius handling for better geometry accuracy
… update example usage for top flange cross-section
@GerjanDorgelo GerjanDorgelo self-assigned this Nov 16, 2025
Copilot AI review requested due to automatic review settings November 16, 2025 17:11
@GerjanDorgelo GerjanDorgelo linked an issue Nov 16, 2025 that may be closed by this pull request
4 tasks
@github-actions
Copy link

Thank you so much for contributing to Blueprints!
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for C-profile steel sections (specifically UNP profiles) by enhancing the CircularCorneredCrossSection class to handle non-90 degree angles. The implementation introduces slope parameters for inner and outer arcs at both vertical and horizontal sections, enabling accurate modeling of tapered flanges common in UNP profiles.

Key changes:

  • Added slope_to_angle and angle_to_slope helper functions for converting between slope percentages and angles
  • Extended CircularCorneredCrossSection with slope parameters and reference point options
  • Implemented UNPSteelProfile class with support for standard profiles and corrosion modeling

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
blueprints/math_helpers.py Added conversion functions between slope percentages and angles
blueprints/structural_sections/cross_section_cornered.py Enhanced to support non-90 degree corners with slope parameters
blueprints/structural_sections/steel/steel_cross_sections/unp_profile.py New UNP profile implementation using enhanced cornered sections
tests/test_math_helpers.py Added tests for slope/angle conversion functions
tests/structural_sections/test_cross_section_cornered.py Updated tests to cover new slope parameters
tests/structural_sections/steel/steel_cross_sections/test_unp_profile.py Comprehensive tests for UNP profile functionality
tests/structural_sections/steel/steel_cross_sections/conftest.py Added fixture for UNP profile testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (605c6ad) to head (159a726).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #825    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          393       394     +1     
  Lines        12106     12220   +114     
==========================================
+ Hits         12106     12220   +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings November 16, 2025 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SZeltaat
Copy link
Contributor

Hi @GerjanDorgelo, Welcome back! 😃
As you've mentioned, I'm currently working on a large refactor which includes the parts you have worked on in this PR. There are some changes in the logic and the way we define steel profiles. The current approach will be deprecated very soon.
If this is not urgent, I want to ask you to wait until those changes are merged and then adopt the new appraoch. If urgent, please let me know and we can figure out a way to meet your needs in the meantime 😉

And please 😭 No large PR's! 😅

@GerjanDorgelo GerjanDorgelo marked this pull request as draft November 17, 2025 08:44
@GerjanDorgelo
Copy link
Contributor Author

@SZeltaat yess correct! if your code is indeed ready soon, i propose merging that one first into the main and then me ammending this PR. and yes now that i know my approach works, ill split this one into two maybe three PRs (once i know what edits it needs to accomodate your changes)

@SZeltaat
Copy link
Contributor

@GerjanDorgelo I'll do my best to get it into main as fast as possible. I'm almost there 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Add steel shapes for C profiles

3 participants