-
Notifications
You must be signed in to change notification settings - Fork 17
Initiate seperatation of checks folder into multiple folders. #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Initiate seperatation of checks folder into multiple folders. #833
Conversation
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR initiates the reorganization of the checks folder by introducing a material-based folder structure. The changes move the nominal concrete cover check from a flat structure into a new concrete subdirectory, establishing a pattern for future separation of checks by material type (with steel planned next).
Key Changes:
- Created new
concretesubdirectory underblueprints/checks/for material-specific organization - Updated import path for
NominalConcreteCoverto reflect new folder structure - Added corresponding test directory structure under
tests/checks/concrete/
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/checks/concrete/nominal_concrete_cover/test_nominal_concrete_cover.py | Updated import path to reference the new concrete subdirectory location |
| tests/checks/concrete/init.py | Added initialization file for concrete test checks subdirectory |
| blueprints/checks/concrete/init.py | Added initialization file for concrete checks subdirectory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 12116 12116
=========================================
Hits 12116 12116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er-for-concrete-steel-more-and
Description
Initiate seperatation of checks folder into multiple folders. For now just the one (but im working on a steel one)
Fixes #832
Type of change
Checklist: