Skip to content

Conversation

@GerjanDorgelo
Copy link
Contributor

Description

Initiate seperatation of checks folder into multiple folders. For now just the one (but im working on a steel one)

Fixes #832

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@GerjanDorgelo GerjanDorgelo self-assigned this Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 08:56
@github-actions
Copy link

Thank you so much for contributing to Blueprints!
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR initiates the reorganization of the checks folder by introducing a material-based folder structure. The changes move the nominal concrete cover check from a flat structure into a new concrete subdirectory, establishing a pattern for future separation of checks by material type (with steel planned next).

Key Changes:

  • Created new concrete subdirectory under blueprints/checks/ for material-specific organization
  • Updated import path for NominalConcreteCover to reflect new folder structure
  • Added corresponding test directory structure under tests/checks/concrete/

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

File Description
tests/checks/concrete/nominal_concrete_cover/test_nominal_concrete_cover.py Updated import path to reference the new concrete subdirectory location
tests/checks/concrete/init.py Added initialization file for concrete test checks subdirectory
blueprints/checks/concrete/init.py Added initialization file for concrete checks subdirectory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (af82b24) to head (00011ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #833   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines        12116     12116           
=========================================
  Hits         12116     12116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings November 18, 2025 11:02
Copilot finished reviewing on behalf of egarciamendez November 18, 2025 11:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[📚 Documentation Issue]: seperate checks folder for concrete, steel and (more)

3 participants