-
Notifications
You must be signed in to change notification settings - Fork 17
837 feature request add latex option for intermediate results #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
837 feature request add latex option for intermediate results #838
Conversation
…7-1+C2:2017 such that it will allign with next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new feature to display intermediate calculation results in LaTeX formula representations, addressing issue #837. The change allows formulas to show not just the final OK/NOT OK result, but also intermediate computational steps like unity check values.
Key Changes:
- Added
intermediate_resultfield toLatexFormulaclass for displaying intermediate calculation steps - Updated formula rendering logic to include intermediate results in complete representations
- Implemented unity check calculations in formulas 6.5 and 6.9 to demonstrate the feature
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| blueprints/codes/latex_formula.py | Added intermediate_result attribute and integrated it into complete/short representations |
| blueprints/codes/eurocode/en_1993_1_1_2005/chapter_6_ultimate_limit_state/formula_6_9.py | Added _unity_check method and intermediate result calculation for compression check |
| blueprints/codes/eurocode/en_1993_1_1_2005/chapter_6_ultimate_limit_state/formula_6_5.py | Added _unity_check method and intermediate result calculation for tension check |
| blueprints/codes/eurocode/nen_9997_1_c2_2017/chapter_2_basic_of_geotechnical_design/formula_2_4.py | Added "CHECK" return symbol (previously missing) |
| blueprints/codes/eurocode/en_1992_1_1_2004/chapter_8_detailing_of_reinforcement_and_prestressing_tendons/formula_8_5.py | Added return symbol for alpha coefficients formula |
| tests/codes/eurocode/nen_9997_1_c2_2017/chapter_2_basic_of_geotechnical_design/test_formula_2_4.py | Updated test expectations to include "CHECK" prefix |
| tests/codes/eurocode/en_1993_1_1_2005/chapter_6_ultimate_limit_state/test_formula_6_9.py | Updated test to expect intermediate unity check result |
| tests/codes/eurocode/en_1993_1_1_2005/chapter_6_ultimate_limit_state/test_formula_6_5.py | Updated test to expect intermediate unity check result |
| tests/codes/eurocode/en_1992_1_1_2004/chapter_8_detailing_of_reinforcement_and_prestressing_tendons/test_formula_8_5.py | Updated test expectations for new return symbol |
| .github/prompts/comparison_tests.prompt.md | Updated documentation example with intermediate result |
| .github/prompts/comparison_formula.prompt.md | Updated documentation example with intermediate result pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 12116 12130 +14
=========================================
+ Hits 12116 12130 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fixes #837
Type of change
Please delete options that are not relevant.
Checklist: