Skip to content

Added kind on Taxes + Extended list of kinds on Fees #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeonidMorozov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added kind on Taxes + Extended list of kinds on Fees #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api_calls/reference/taxes/create-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"taxes": [
{
"name_en": "Tax",
"kind": "other",
"start_date": "START_DATE",
"end_date": "END_DATE",
"notes": "Private notes",
Expand Down
1 change: 1 addition & 0 deletions api_calls/reference/taxes/public-scope-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"account": 1
},
"id": 4,
"kind": "other",
"percentage": "10.0",
"created_at": "CREATED_AT",
"updated_at": "UPDATED_AT",
Expand Down
1 change: 1 addition & 0 deletions api_calls/reference/taxes/rates_read-rates_write-scope-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"account": 1
},
"id": 4,
"kind": "other",
"percentage": "10.0",
"created_at": "CREATED_AT",
"updated_at": "UPDATED_AT",
Expand Down
1 change: 1 addition & 0 deletions api_calls/reference/taxes/update-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"taxes": [
{
"name_en": "Tax",
"kind": "other",
"start_date": "START_DATE",
"end_date": "END_DATE",
"notes": "Private notes"
Expand Down
5 changes: 5 additions & 0 deletions content/reference/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 2018-02-01

* [api improvement] Add `kind` on `taxes` endpoint.
* [api improvement] Extend list of `kinds` on `fees` enums.

## 2017-11-08

* [doc update] Add `bookings_taxes percentage` to `bookings` endpoint
Expand Down
3 changes: 3 additions & 0 deletions content/reference/endpoints/taxes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Name | Type | Read/Write | Description
id | Integer | Read | Tax's id.
-----------------|---------|------------|------------
name | [Object](/reference/enums#formats) | Read | Tax's name, list of locales described in [enums section](/reference/enums#locales).
kind | String | Read | Tax's kind, list of tax's kinds described in [enums section](/reference/enums#tax-kinds)
percentage | [Decimal](/reference/enums#formats) | Read | Tax's percentage.
-----------------|---------|------------|------------
created_at | [Time](/reference/enums#formats) | Read | Tax's create time.
Expand All @@ -31,6 +32,7 @@ Name | Type | Read/Write | Description
id | Integer | Read | Tax's id.
-----------------|---------|------------|------------
name | [Object](/reference/enums#formats) | Read | Tax's name, list of locales described in [enums section](/reference/enums#locales).
kind | String | Read | Tax's kind, list of tax's kinds described in [enums section](/reference/enums#tax-kinds)
notes | String | Read | Tax's private notes.
percentage | [Decimal](/reference/enums#formats) | Read | Tax's percentage.
-----------------|---------|------------|------------
Expand All @@ -46,6 +48,7 @@ Name | Type | Read/Write | Description
id | Integer | Read | Tax's id.
-----------------|---------|------------|------------
name | [Object](/reference/enums#formats) | Read/Write | Tax's name, list of locales described in [enums section](/reference/enums#locales).
kind | String | Read/Write | Tax's kind, list of tax's kinds described in [enums section](/reference/enums#tax-kinds)
notes | String | Read/Write | Tax's private notes.
percentage | [Decimal](/reference/enums#formats) | Read/Write | Tax's percentage. Writable only during creation.
-----------------|---------|------------|------------
Expand Down
55 changes: 54 additions & 1 deletion content/reference/enums.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,64 @@ rental_price | Price for the rent only, after all discount
final_price | Price including all required fees and taxes.
{: class="table table-bordered"}

## Tax kinds

Name | Description
--------------------------------|------------
value_added | Value added tax (VAT)
city | City tax
goods_and_services | Goods and services tax
government | Government tax
spa | Spa tax
hot_spring | Hot spring tax
residential | Residential tax
sauna_fitness_facilities | Sauna/fitness facilities tax
local_council | Local council tax
provincial_sales | Provincial sales tax
harmonized_sales | Harmonized sales tax
other | Any other type of tax
{: class="table table-bordered"}

## Fee kinds

Name | Description
-----------------------------|------------
cleaning | Cleaning fee
city_tax | City tax fee
resort | Resort fee
service_charge | Service charge
tourism | Tourism fee
destination | Destination fee
environment | Environment fee
municipality | Municipality fee
public_transit_day_ticket | Public transit day ticket
heritage_charge | Heritage charge
cleaning | Cleaning
towel_charge | Towel charge
electricity | Electricity fee
bed_linen | Bed linen fee
gas | Gas fee
oil | Oil fee
wood | Wood fee
water_usage | Water usage fee
transfer | Transfer fee
linen_package | Linen package fee
heating | Heating fee
air_conditioning | Air conditioning fee
kitchen_linen | Kitchen linen fee
housekeeping | Housekeeping fee
airport_shuttle | Airport shuttle fee
shuttle_boat | Shuttle boat fee
sea_plane | Sea plane fee
ski_pass | Ski pass
final_cleaning | Final cleaning fee
wristband | Wristband fee
visa_support | Visa support fee
water_park | Water park fee
club_card | Club card fee
conservation | Conservation fee
credit_card | Credit card fee
internet | Internet fee
parking | Parking fee
other | Any other type of fee
{: class="table table-bordered"}

Expand Down