Open
Conversation
added 8 commits
July 24, 2023 10:19
…ent paths to the credentials file - making them consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging within the api code should not fix the logging config in a way that is hard to overwrite, for code which will import it. As discussed in #35
This PR does a couple of logging related things things:
The log level can still be changed but is not overridden by this code.
The default log level is now WARNING. This makes the default much less verbose. It can easily be changed, as was already documented. Will this change confuse users?
In testing and tweaking the demo I also hit an issue with the token storage in a fresh clone of the API:
bcr-authenticatehad a default tokens file of~/.bcr/credentials.txtBWProjectandBWUserhad a default location of./tokens.txtbcr-authenticateto providingtokens.txtin example calls, when that file was non-existent or empty and so led to errors.A missing user in the tokens file also led to an unhelpful exception message, which I've addressed.
I've made
BWProjectandBWUsershare the same default asbcr-authenticate.If code has been written assuming
tokens.txtrather than explicitly providing it this will break.The DEMO notebook has been updated to comment on this, but for existing code this may be a breaking change.
It would be easy to make
tokens.txtthe default, but I assume that a central location was introduced for a reason.