Network check #20
Open
Network check #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2014 23:05
If there is no internet connection, subsequent downloads will (obviously) not work- lets catch this error early. Current code structure allows the failure to occur but continues on as a success
In the off case the user has already set up an ssh key as the non-priv user, this will make sure that same user's ssh key is used to connect with github, instead of the root key which is what would be used when this script is executed via sudo. Logname gives us the initiating user's login name, instead of using root.
Member
|
The run git as user commit, does it actually do anything? |
Collaborator
Author
|
logname checks the user who initiated the sudo command. git fetch is being run as the root user, as it was called via the sudo command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if network connectivity is available before running script- if we can't connect to the internet, how can we update!