Skip to content

Change create event route #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angeljruiz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change create event route #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
resource :user, except: %i[new edit]
get '/user/valid', to: 'users#valid'
post 'login', to: 'sessions#create'
post '/contact', to: 'contact#create'

resources :bridges, param: :slug do
patch 'activate'
Expand All @@ -16,13 +17,11 @@

resources :headers, :environment_variables, only: :destroy

post '/:bridge_slug', to: 'events#create'
Copy link
Collaborator

@AndiLavera AndiLavera Dec 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think namespacing it update events is more conventional?

patch 'events/abort', to: 'events#abort'
post 'events/:bridge_slug', to: 'events#create'
get 'events', to: 'events#index'
get 'events/:event_id', to: 'events#show'
delete 'events/:event_id', to: 'events#destroy'

post '/contact', to: 'contact#create'

mount Sidekiq::Web => '/sidekiq'
end
20 changes: 10 additions & 10 deletions spec/requests/events_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,15 @@
headers = { 'CONTENT_TYPE' => 'application/json' }
expect(EventWorker.jobs.count).to eq 0

post "/events/#{@bridge.slug}", params: '{ "data": { "hello": "world" } }', headers: headers
post "/#{@bridge.slug}", params: '{ "data": { "hello": "world" } }', headers: headers

expect(EventWorker.jobs.count).to eq 1
expect(response).to have_http_status(202)
end

it 'returns 400 with invalid IDs' do
headers = { 'CONTENT_TYPE' => 'application/json' }
post '/events/128371283', params: '{ "data": { "hello": "world" } }', headers: headers
post '/128371283', params: '{ "data": { "hello": "world" } }', headers: headers
expect(response).to have_http_status(400)
end
end
Expand All @@ -156,7 +156,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_ids.push(JSON.parse(response.body)['id'])
end
end.to change(EventWorker.jobs, :count).by(3)
Expand All @@ -180,7 +180,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_id = JSON.parse(response.body)['id']
end
end.to change(EventWorker.jobs, :count).by(3)
Expand All @@ -202,7 +202,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_ids.push(JSON.parse(response.body)['id'])
end
end.to change(EventWorker.jobs, :count).by(3)
Expand All @@ -228,15 +228,15 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_ids.push(JSON.parse(response.body)['id'])
end
end.to change(EventWorker.jobs, :count).by(3)

expect(response).to have_http_status(202)
@token = JsonWebToken.encode(user_id: User.second)

post '/events/abort', headers: authenticated_token
post '/abort', headers: authenticated_token

expect(event_ids.all? do |id|
event = Event.find(id)
Expand All @@ -253,7 +253,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_id = JSON.parse(response.body)['id']
end
end.to change(EventWorker.jobs, :count).by(3)
Expand All @@ -276,7 +276,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_ids.push(JSON.parse(response.body)['id'])
end
end.to change(EventWorker.jobs, :count).by(3)
Expand All @@ -301,7 +301,7 @@

expect do
3.times do
post "/events/#{@bridge.slug}", params: invalid_payload, headers: headers
post "/#{@bridge.slug}", params: invalid_payload, headers: headers
event_id = JSON.parse(response.body)['id']
end
end.to change(EventWorker.jobs, :count).by(3)
Expand Down