Make Arbitrary::arbitrary for SystemTime not panic #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arbitrary `SystemTime`s are generated based on arbitrary `Duration`s by adding or subtracting from `UNIX_EPOCH`. If we happen to generate big `Duration`s, this could cause an overflow. This change avoids this problem by resorting to ever smaller durations in case of an overflow.
neithernut
force-pushed
the
systemtime-no-overflow
branch
from
4623f40 to
2e4ba41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary
SystemTimes are generated based on arbitraryDurations by adding or subtracting fromUNIX_EPOCH. If we happen to generate bigDurations, this could cause an overflow.This change avoids this problem by resorting to ever smaller durations in case of an overflow.
Fixes #321.