fix: add -- separator before filename in compression tools#3314
Open
mango766 wants to merge 1 commit intoBurntSushi:masterfrom
Open
fix: add -- separator before filename in compression tools#3314mango766 wants to merge 1 commit intoBurntSushi:masterfrom
mango766 wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
When decompressing files with names starting with a dash (e.g., -10.txt.gz), tools like gzip interpret the filename as options. Adding '--' before the filename follows POSIX end-of-options convention to prevent this misinterpretation. Fixes BurntSushi#3222 Co-Authored-By: Claude (GLM-4.7) <noreply@anthropic.com>
1 task
|
Prior art: #3224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching compressed files with names that start with a dash (e.g.,
-10.txt.gz), ripgrep fails because the compression tool interprets the filename as command options.Here's the issue that this PR addresses:
This happens because ripgrep calls compression tools like
gzip -d -c -10.txt.gz, where-10.txt.gzgets parsed as invalid options.The fix is simple: add
--before the filename argument. This is the standard POSIX "end of options" marker that tells the tool everything following it should be treated as positional arguments, not options.After this fix:
This aligns with how most shell commands handle filenames that might be confused with options.
Fixes #3222