fix(ignore): avoid nanosleep busy loop in worker fallback (#2761)#3327
Open
krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
Open
fix(ignore): avoid nanosleep busy loop in worker fallback (#2761)#3327krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2761
Summary
Fixes a busy-loop fallback in ignore walker worker scheduling that could spin in nanosleep while another worker is blocked on a FIFO.
Problem
When one worker blocks on a FIFO, other workers can enter a repeated nanosleep cycle in Worker::get_work instead of yielding cleanly.
What changed
Solution
Use std::thread::yield_now() in the non-blocking stack fallback path so workers stop burning CPU while waiting for progress.
Why
This preserves behavior while reducing unnecessary syscall/CPU churn in stalled traversal scenarios.
Tests
cargo test -p ignore walk -- --nocapturecargo test -p ripgrep --tests