fix(#2820): --files now correctly handles implicit pattern argument#3343
Open
xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
Open
fix(#2820): --files now correctly handles implicit pattern argument#3343xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
…argument When using --files with positional arguments, the first positional was incorrectly treated as a path when it would have been a pattern in search mode. This caused --files to list files outside the intended search path. The fix: When --files (or other non-search modes) has multiple positional arguments and no explicit patterns via -e/-f, skip the first positional as it would be the pattern in search mode. Example: rg '.' node_modules --files Before: Listed files from '.' (current dir) and node_modules After: Only lists files from node_modules (the intended search path) We only apply this when there are >= 2 positionals: - Single positional (like --files .) is an intentional path - Multiple positionals suggests pattern + path(s) This ensures --files lists files that would actually be searched. Signed-off-by: xingzihai <xingzihai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using --files with positional arguments, the first positional was incorrectly treated as a path when it would have been a pattern in search mode. This caused --files to list files outside the intended search path.
The fix: When --files (or other non-search modes) has multiple positional arguments and no explicit patterns via -e/-f, skip the first positional as it would be the pattern in search mode.
Example:
rg "." node_modules --filesBefore: Listed files from "." (current dir) and node_modules
After: Only lists files from node_modules (the intended search path)
This ensures --files lists files that would actually be searched.
Fixes #2820