3.5.1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rosi",
-  "version": "3.5.0",
+  "version": "3.5.1",
   "private": true,
   "description": "Electron GUI for yt-dlp",
   "keywords": [

src/main/download/commandBuilders.ts

@@ -1,10 +1,16 @@
-import type { DownloadRequestOptions, Settings } from '../../types';
+import type { DownloadRequestOptions, GpuDetectionResult, Settings } from '../../types';
+import { detectGpu } from '../gpu';
 
-export function resolveVideoEncoder(settings: Settings): string {
+export async function resolveVideoEncoder(settings: Settings): Promise<string> {
   if (!settings.gpuAcceleration) return 'copy';
   if (settings.gpuType === 'nvidia') return 'h264_nvenc';
   if (settings.gpuType === 'amd') return 'h264_amf';
   if (settings.gpuType === 'intel') return 'h264_qsv';
+
+  const detected: GpuDetectionResult = await detectGpu();
+  if (detected.nvidia) return 'h264_nvenc';
+  if (detected.amd) return 'h264_amf';
+  if (detected.intel) return 'h264_qsv';
   return 'copy';
 }
 

src/main/downloader.ts

@@ -171,7 +171,7 @@ export function cancelFormats() {
   }
 }
 
-function runConversion(
+async function runConversion(
   session: DownloadSession,
   downloadedFilePath: string,
   effectiveSettings: Settings,
@@ -222,7 +222,7 @@ function runConversion(
 
     sendProgress(session, `🎬 Converting ${inputFilename} to ${targetFormat.toUpperCase()}...`);
 
-    const videoEncoder = resolveVideoEncoder(effectiveSettings);
+    const videoEncoder = await resolveVideoEncoder(effectiveSettings);
     const useGpu = effectiveSettings.gpuAcceleration && videoEncoder !== 'copy';
 
     if (useGpu) {
@@ -466,7 +466,13 @@ export function startDownload(
       }
 
       if (effectiveSettings.convertEnabled) {
-        runConversion(session, downloadedFilePath, effectiveSettings, ffmpegCommand, mainWindow);
+        void runConversion(
+          session,
+          downloadedFilePath,
+          effectiveSettings,
+          ffmpegCommand,
+          mainWindow
+        );
       } else {
         sendProgress(session, 'ℹ️ Conversion not enabled for this download.');
         completeSession(session, '✅ Download complete (no conversion).');

src/main/main.ts

@@ -20,7 +20,7 @@ import {
   fetchFormats,
   cancelFormats,
 } from './downloader';
-import { isSafeExternalUrl, isAllowedNavigationUrl } from '../utils/validation';
+import { isSafeExternalUrl, isSafeHttpUrl, isAllowedNavigationUrl } from '../utils/validation';
 import {
   errorResult,
   okResult,
@@ -222,7 +222,7 @@ ipcMain.handle('select-download-location', async () => {
 });
 
 ipcMain.handle('getFormats', (_, url) => {
-  if (typeof url !== 'string') {
+  if (typeof url !== 'string' || !isSafeHttpUrl(url)) {
     return Promise.reject('Invalid URL provided');
   }
   return fetchFormats(ytdlpPath, url);

src/renderer/splash.html

@@ -265,6 +265,6 @@ <h1 class="app-title">ROSI</h1>
         <div class="loading-bar"></div>
       </div>
     </div>
-    <div class="version" id="version-display">v3.5.0</div>
+    <div class="version" id="version-display">v3.5.1</div>
   </body>
 </html>