Skip to content

Conversation

@Golbstein
Copy link
Contributor

we actually return w2c as extrinsic

@jianglh-WHU
Copy link

I think the author might have reversed the direction and origin in the paper.
image
Because ⬇️ Obviously, direction is in the first three channels.

R, focal_lengths, principal_points = compute_optimal_rotation_intrinsics_batch(
I_cam_plane_unproj,
camray[:, :, :3],
reproj_threshold=reproj_threshold,
weights=confidence,
n_sample = n_sample,
n_iter=n_iter,
num_sample_for_ransac=num_sample_for_ransac,
rand_sample_iters_idx=rand_sample_iters_idx,
)

@Golbstein
Copy link
Contributor Author

yes, they did. but that's a PR for their paper ;)

@jianglh-WHU
Copy link

hh, just discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants