Skip to content

fix: getPossibleTargets select correct targets #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2025
Merged

fix: getPossibleTargets select correct targets #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a911ec8
fix: getPossibleTargets select correct targets
C4illin Nov 15, 2025
0df7f7a
Merge branch 'main' into fix/getPossibleTagets-select-correct-targets
C4illin Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 8 additions & 43 deletions src/converters/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,22 +245,18 @@ const possibleTargets: Record<string, Record<string, string[]>> = {};

for (const converterName in properties) {
const converterProperties = properties[converterName]?.properties;

if (!converterProperties) {
continue;
}
if (!converterProperties) continue;

for (const key in converterProperties.from) {
if (converterProperties.from[key] === undefined) {
continue;
}
const fromList = converterProperties.from[key];
const toList = converterProperties.to[key];

for (const extension of converterProperties.from[key] ?? []) {
if (!possibleTargets[extension]) {
possibleTargets[extension] = {};
}
if (!fromList || !toList) continue;

for (const ext of fromList) {
if (!possibleTargets[ext]) possibleTargets[ext] = {};

possibleTargets[extension][converterName] = converterProperties.to[key] || [];
possibleTargets[ext][converterName] = toList;
}
}
}
Expand Down Expand Up @@ -289,11 +285,6 @@ for (const converterName in properties) {
}
possibleInputs.sort();

// eslint-disable-next-line @typescript-eslint/no-unused-vars
const getPossibleInputs = () => {
return possibleInputs;
};

const allTargets: Record<string, string[]> = {};

for (const converterName in properties) {
Expand Down Expand Up @@ -336,29 +327,3 @@ for (const converterName in properties) {
export const getAllInputs = (converter: string) => {
return allInputs[converter] || [];
};

// // count the number of unique formats
// const uniqueFormats = new Set();

// for (const converterName in properties) {
// const converterProperties = properties[converterName]?.properties;

// if (!converterProperties) {
// continue;
// }

// for (const key in converterProperties.from) {
// for (const extension of converterProperties.from[key] ?? []) {
// uniqueFormats.add(extension);
// }
// }

// for (const key in converterProperties.to) {
// for (const extension of converterProperties.to[key] ?? []) {
// uniqueFormats.add(extension);
// }
// }
// }

// // print the number of unique Inputs and Outputs
// console.log(`Unique Formats: ${uniqueFormats.size}`);
Loading