Minor feature update #162
Open
Minor feature update #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n just falling back
…s wrong Show filename on MouseHover in TabControl
# Conflicts: # EDSEditorGUI/DeviceODView.Designer.cs # EDSEditorGUI/DeviceODView.cs # libEDSsharp/CanOpenNodeExporter.cs
nimrof
requested changes
Jan 14, 2025
Collaborator
nimrof
left a comment
nimrof
left a comment
There was a problem hiding this comment.
Looks good, just a few comments and i to me the change here introduces a bug.
If you create a device then remove it save in the menu is not disabled
CANopenEditor/EDSEditorGUI/Form1.Designer.cs
Line 299 in 0c97545
My nitpicking brain may also want to revert the changes in tabControl1_MouseClick as there is no actual change AFIK, but feel free to ignore that
EDSEditorGUI/Form1.cs
Outdated
| using static System.Windows.Forms.VisualStyles.VisualStyleElement; | ||
| //using static System.Windows.Forms.VisualStyles.VisualStyleElement; | ||
| //using SourceGrid.Cells.Controllers; | ||
| //using ToolTip = System.Windows.Forms.ToolTip; |
Collaborator
There was a problem hiding this comment.
maybe remove the commented code?
EDSEditorGUI/Form1.resx
Outdated
| Sq4NMHLMowQdiucH/4Pfs7VzE+N+UlgC2l9c92MYCO0CtYrrfh+7bu0ECD4DV0bDX6oC05+kVxpa9Ajo | ||
| 2QYurhuaugdc7gD9T6ZiKZ4UpBJyOeD9jL4pA/TeAp2r/tzq5zh9AFI0q8QNcHAIjOQpe63Fuzua5/bn | ||
| HW9+kH4AMgFyjcd8GS4AAAAJcEhZcwAACw4AAAsOAUC+4UEAAAAHdElNRQfkCwILIglO4xvLAAAAD3RF | ||
| HW9+kH4AMgFyjcd8GS4AAAAJcEhZcwAACwwAAAsMAT9AIsgAAAAHdElNRQfkCwILIglO4xvLAAAAD3RF |
Collaborator
There was a problem hiding this comment.
need a little help with the changes here :D
Co-authored-by: Lars Elgtvedt Susaas <lars.elgtvedt.susaas@brunvoll.no>
Co-authored-by: Lars Elgtvedt Susaas <lars.elgtvedt.susaas@brunvoll.no>
The count label is required to compile against the CANopenNode v4
library since the definitions are checked by code like the following
in CANopen.c
#if OD_CNT_NMT != 1
#error OD_CNT_NMT from OD.h not correct!
#endif
This problem is exhibited when there is no xpd file that has the
custom properties and there is only an EDS file available. The
StorageLocation is an example of setting the custom property for
the CO_storageGroup and this is adding a similar extension for
the CO_countLabel.
An example eds for NMT 0x1000 is shown below
[1000]
ParameterName=Device type
ObjectType=0x7
;CountLabel=NMT
;StorageLocation=ROM
DataType=0x0007
AccessType=ro
DefaultValue=0x00000000
PDOMapping=0
Signed-off-by: Charles Hardin <charles.hardin@redoxblox.com>
Collaborator
|
@trojanobelix That last commit changed a lot, do you have a list of the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/extend some exception catches to provide more information what was wrong
Show filename on MouseHover in TabControl