Chore(Next-Gen): enable pre-commits for CAREamistV2

[jdeschamps]

Description

Following #827, this PR enables pre-commit hooks for CAREamistV2 and attempts to solve the errors.

Note that there is something fishy with the use of TypeVar that mypy disagrees with:

src/careamics/careamist_v2.py:128: error: Argument 1 to "_load_model" of "CAREamistV2" has incompatible type "NGConfiguration[CAREAlgorithm] | Path | None"; expected "NGConfiguration[AlgorithmConfig] | Path | None"  [arg-type]
src/careamics/careamist_v2.py:128: error: Argument 1 to "_load_model" of "CAREamistV2" has incompatible type "NGConfiguration[N2NAlgorithm] | Path | None"; expected "NGConfiguration[AlgorithmConfig] | Path | None"  [arg-type]
src/careamics/careamist_v2.py:128: error: Argument 1 to "_load_model" of "CAREamistV2" has incompatible type "NGConfiguration[N2VAlgorithm] | Path | None"; expected "NGConfiguration[AlgorithmConfig] | Path | None"  [arg-type]
Found 3 errors in 1 file (checked 1 source file)

One way to solve it to redefine AlgorithmConfig in the same module, rather than importing it. It seems that allows "bounding" the type to the functions it is used in.

But it would be annoying to have to redefine the generics in every module. I decided to just ignore it for now for two reasons:

• Feat(Next-Gen): callbacks as dict in NGTrainingConfig, default preset by algorithm #817 introduces a validator that may improve the situation
• Maybe pyright (Switch from mypy to basedpyright #698) will be better suited

[melisande-c]

hmm yeah I think maybe this is one of those things pyright is fine with but mypy complains, and now I don't remember why I made the configuration a generic, sorry for complicating things. But a solution here is to replace the typing of the config arg in the __init__ to this:

NGConfigurationType = (
    NGConfiguration[CAREAlgorithm]
    | NGConfiguration[N2NAlgorithm]
    | NGConfiguration[N2VAlgorithm]
)

[jdeschamps]

hmm yeah I think maybe this is one of those things pyright is fine with but mypy complains, and now I don't remember why I made the configuration a generic, sorry for complicating things. But a solution here is to replace the typing of the config arg in the __init__ to this:

NGConfigurationType = (
    NGConfiguration[CAREAlgorithm]
    | NGConfiguration[N2NAlgorithm]
    | NGConfiguration[N2VAlgorithm]
)

No need to apologize. It is a bit annoying that generics are so annoying in Python (at least for mypy). Maybe another nail in the coffin.

Implemented the change in 68b39be

[melisande-c]

Looks good

[melisande-c]

damn it something else that works with pyright but not mypy, this is happening bec mypy can't resolve overloads that well

[jdeschamps]

Yep... Moving to pyright is just going to feel good I surmise.