Add differentiating badge icon for issues and PRs#483
Add differentiating badge icon for issues and PRs#483bipplane wants to merge 7 commits intoCATcher-org:mainfrom
Conversation
NorbertLoh
left a comment
There was a problem hiding this comment.
Nits to fix. Perhaps we should see if @damithc is ok with the colour choice. Otherwise LGTM! 👍
|
this could serve as a starting point for default colour. in the future, maybe we could let users choose their own desired colour for both issues and prs. |
I'm OK with the colour. One downside is that we use purple to indicate the merged status. But I can't think of a better choice either. |
i agree that multiple bg colours would probably not work well. and from a user's perspective, questions like 'what does this colour mean' and 'why is it in this colour' may also be potentially brought up in the future. changing the background colour was a pretty simple implementation in my opinion - if given more time, i can try to work something out and see if i'm able to have distinguishing features, without causing too much chaos in the current UI. |
|
hi all, I have addressed the feedback and pushed new commits, this time using a badge display to differentiate issues/PRs instead of background colours. do let me know your thoughts! |



Summary:
Fixes #480
Type of change:
Changes Made:
Screenshots:
Homepage
Hover tooltips
Proposed Commit Message:
Checklist: