Open
Conversation
Release v2.1.2
Release v2.1.3
Release v2.1.4
Release v2.2.0
Release v2.2.1
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the GDCMVS application by migrating from Webpack to Vite, updating dependencies, and modernizing the codebase. The changes include removing deprecated packages, updating build configurations, and improving browser compatibility.
- Migrated build system from Webpack to Vite for improved development experience
- Updated package dependencies to newer versions and removed deprecated packages
- Modernized frontend code with Bootstrap 5 compatibility and improved styling
Reviewed Changes
Copilot reviewed 50 out of 54 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies and changed build scripts to use Vite |
| vite.config.js | New Vite configuration replacing Webpack setup |
| webpack/* | Removed all Webpack configuration files |
| server/service/search/*.js | Updated YAML library and commented out Excel parsing functionality |
| client/src/* | Modernized frontend code with template tags and Bootstrap 5 compatibility |
Comments suppressed due to low confidence (1)
client/src/dialog/to-compare/to-compare-view.js:1
- Element ID has a typo. Should be 'tab-properties' instead of 'tap-properties' to match the expected naming convention.
import { tableSynonyms, tableIcdo3 } from '../../components/table';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Convert all array fields in tmp_data to string, or if empty string "" | ||
| Object.keys(tmp_data).forEach(key => { | ||
| if (Array.isArray(tmp_data[key])) { | ||
| data[key] = Array.isArray(data[key]) && data[key].length > 0 ? data[key].join('|') : ""; |
There was a problem hiding this comment.
Variable name mismatch. The condition checks 'tmp_data[key]' but assigns to 'data[key]'. This should be 'tmp_data[key] = ...' to match the intended logic.
Suggested change
| data[key] = Array.isArray(data[key]) && data[key].length > 0 ? data[key].join('|') : ""; | |
| tmp_data[key] = tmp_data[key].length > 0 ? tmp_data[key].join('|') : ""; |
bensonml
force-pushed
the
gdcmvs-upgrade
branch
from
b4f3635 to
ad02930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.