Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the master branch with Node 16 compatibility changes, including Bootstrap v3 to v5 upgrades and dependency updates. The changes focus on removing deprecated Google Sheets integration code and updating package dependencies to newer versions compatible with Node 16.
Key Changes:
- Removal of unused Google Sheets OAuth2 integration code and credentials
- Package dependency version updates for Node 16 compatibility
- Addition of security overrides for vulnerable dependencies
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/service/search/index.js | Removes commented-out route for Google Sheets management |
| server/service/search/googleSheets.js | Removes unused manageSheets function and googleapis import |
| package.json | Updates dependencies to Node 16-compatible versions and adds security overrides |
| credentials.json | Deletes Google OAuth2 credentials file (no longer needed) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "@babel/preset-env": "^7.28.0", | ||
| "babel-eslint": "^10.1.0", | ||
| "babel-loader": "^8.1.0", | ||
| "babel-loader": "^ 8.4.1", |
There was a problem hiding this comment.
Corrected spacing in version string: removed space after '^' in '^ 8.4.1'.
| "babel-loader": "^ 8.4.1", | |
| "babel-loader": "^8.4.1", |
| function listMajors(auth) { | ||
| read_data(auth); |
There was a problem hiding this comment.
The listMajors function is now orphaned after removing manageSheets. Based on the context showing read_data depends on the google object which was removed with the googleapis import, this function and its dependencies should also be removed to avoid dead code.
1ad6f6b to
64f557f
Compare
Updates
masterfromgdcmvs-upgrade-node-16Contains various updates, including