Skip to content

update master with node16 updates#112

Open
bensonml wants to merge 1 commit intomasterfrom
gdcmvs-upgrade-node-16
Open

update master with node16 updates#112
bensonml wants to merge 1 commit intomasterfrom
gdcmvs-upgrade-node-16

Conversation

@bensonml
Copy link

Updates master from gdcmvs-upgrade-node-16
Contains various updates, including

@bensonml bensonml requested a review from Copilot October 21, 2025 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the master branch with Node 16 compatibility changes, including Bootstrap v3 to v5 upgrades and dependency updates. The changes focus on removing deprecated Google Sheets integration code and updating package dependencies to newer versions compatible with Node 16.

Key Changes:

  • Removal of unused Google Sheets OAuth2 integration code and credentials
  • Package dependency version updates for Node 16 compatibility
  • Addition of security overrides for vulnerable dependencies

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
server/service/search/index.js Removes commented-out route for Google Sheets management
server/service/search/googleSheets.js Removes unused manageSheets function and googleapis import
package.json Updates dependencies to Node 16-compatible versions and adds security overrides
credentials.json Deletes Google OAuth2 credentials file (no longer needed)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"@babel/preset-env": "^7.28.0",
"babel-eslint": "^10.1.0",
"babel-loader": "^8.1.0",
"babel-loader": "^ 8.4.1",
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spacing in version string: removed space after '^' in '^ 8.4.1'.

Suggested change
"babel-loader": "^ 8.4.1",
"babel-loader": "^8.4.1",

Copilot uses AI. Check for mistakes.
Comment on lines 5 to 6
function listMajors(auth) {
read_data(auth);
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The listMajors function is now orphaned after removing manageSheets. Based on the context showing read_data depends on the google object which was removed with the googleapis import, this function and its dependencies should also be removed to avoid dead code.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants