Decoding compressed latitude and longitude#179
Merged
CBielstein merged 2 commits intoCBielstein:mainfrom Oct 5, 2025
Merged
Conversation
Owner
|
@aschuhardt Just commenting to acknowledge that I have seen this PR. Real life and day job have been extremely busy the last few weeks. I will get to a review soon. Thank you! |
CBielstein
approved these changes
Oct 5, 2025
Owner
CBielstein
left a comment
CBielstein
left a comment
There was a problem hiding this comment.
This looks great! Clean code and follows the spec well. There are two little silly linter errors, but I'll fix those up as you did all the work here. Thanks much. :)
Merged
CBielstein
added a commit
that referenced
this pull request
Oct 5, 2025
## Description #179 introduced a few minor static analysis violations. This is okay, because it also brought great functionality. :) Not worth going through another round of PR for minor fixes, and this is easier than playing branch shenanigans. ## Changes * Fixes for the linter ## Validation * Build passes clean on my machine, we'll see it in the CI as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to be able to decode compressed position reports.
I did not add support for parsing the optional extra data (course/speed, altitude, etc.) from the compressed format, since this would likely involve refactoring some other part of the
Positionclass. I'll add support for this sometime soon if nobody else does, assuming this PR is merged.Changes
I added logic to
Positionwhich, if a set of coordinates doesn't look like uncompressed coordinates, will try to parse them as compressed coordinates instead. This logic leverages an additional regex pattern.Validation
I added a test case to
PositionUnitTests.Decodefor a set of coordinates and expected values which I pulled from the APRS spec.