Resolves issue#827, where timeUntilAlarm wasn't working as Expected#833
Resolves issue#827, where timeUntilAlarm wasn't working as Expected#833Gaurav-Kushwaha-1225 wants to merge 4 commits intoCCExtractor:mainfrom
timeUntilAlarm wasn't working as Expected#833Conversation
|
In the latest commit, I also resolved a problem in calculating the rings in value for an alarm, set for repeat on a day which is the same as today. Like in the video below, today is Friday, and 'Rings in' was giving "Rings in No upcoming alarms", instead of "Rings in 6 days", when set the repeating day as Friday itself.
|
80d7967 to
7803a1e
Compare
|
Hii @Gaurav-Kushwaha-1225 take a look at PR(#830) which has good UI/UX and solves the ringson issue , rings in duration |
|
Hi @mahendra-918, I saw your PR (#830) — it looks good! However, I noticed that you've made some significant changes to the UI as well. The original issue #827 you addressed was specifically about the bug in the If you are planning to implement any additional ideas, it would be better to discuss them first in the Zulip discussion group to get some feedback from mentors and community members. |
Description
Now, the alarm scheduling logic incorporates the
alarmDateparameter into thetimeUntilAlarmfunction for the calculation of a non-repeating alarm that's scheduled after some days.Also, you can refer to this small discussion #gsoc-ultimate-alarm-clock > @ 💬, regarding the
RepeatandRings Onfeature, where it was proposed to disable theRings Onwhen Repeat is enabled, or vice versa.Proposed Changes
Added
alarmDateParameter: ThetimeUntilAlarmfunction now accepts an additional alarmDate parameter to handle date-based alarm scheduling.Controller Updates: Now, if
Rings Onis enabled orselectedDate != DateTime.now(), then make theRepeatas Never orrepeatDays = [false, false, false, false, false, false, false]. Or, vice versa.Fixes #827
Screenshots
In the video below, the calculation for
Rings in __is now accurate for alarms set on a specific date. And, selecting both a specific date alarm and a repeat alarm is not possible, since enabling one will disable the other.Record_2025-04-25-01-01-03.mp4
Checklist