Optimize Docker build by introducing shared runtime-deps stage#49
Merged
payneBrandon merged 5 commits intodevelopfrom Sep 26, 2025
Merged
Optimize Docker build by introducing shared runtime-deps stage#49payneBrandon merged 5 commits intodevelopfrom
runtime-deps stage#49payneBrandon merged 5 commits intodevelopfrom
Conversation
dmccoystephenson
requested review from
mcook42,
payneBrandon and
pmonington
do_kafka_test.sh
Outdated
| } | ||
|
|
||
| waitForKafkaToCreateTopics() { | ||
| sleep 1 # give Kafka a moment to start |
There was a problem hiding this comment.
question: rather than sleep should we do a health check?
Member
Author
There was a problem hiding this comment.
That works for me, especially if Kafka takes more than a second to start on the user’s computer.
mcook42
approved these changes
Sep 23, 2025
pmonington
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Runtime dependencies were being installed separately in both the builder and runtime images. This duplication increased build times and added unnecessary complexity.
Solution
A new intermediate build stage,
runtime-deps, has been added. Both the builder and runtime stages now reference this shared stage instead of installing runtime dependencies independently.Testing
do_kafka_test.shscript completes successfullyAdditional Changes
.gitignorewas added for .pyc filesdo_kafka_test.shto give Kafka a moment to start before checking for topics