Skip to content

Hazard forecast concat test #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peanutfun merged 25 commits into from
Dec 8, 2025
Merged

Hazard forecast concat test #1178

peanutfun merged 25 commits into from
Dec 8, 2025

Conversation

@luseverin
Copy link
Collaborator

@luseverin luseverin commented Dec 8, 2025

Changes proposed in this PR:

  • Add test to check whether Hazard.concat works with hazardForecast

TODO:

  • Adapt concat so that it actually works with hazardForecast

This PR fixes #1165

PR Author Checklist

PR Reviewer Checklist

luseverin and others added 23 commits December 8, 2025 11:39
@luseverin
Create hazardForecast base class
ea1f91a
@luseverin
Add from_hazard method in hazardForecast
4e25382
@luseverin
Remove duplicate file
03a9cf7
@luseverin
Give explicit name to kwards
5adaccb
@luseverin
Split hazard_kwargs and dummy hazard in hazard base test
55883d8
@luseverin
Draft test init hazardForecast
e94be48
@luseverin
Merge branch 'forecast-class' into hazardForecast_base_class
d78ef72
@luseverin
Correct error in hazard_kwargs test base
38b2fc5
@luseverin
Correct import
3a2a024
@luseverin
Correct use of fixtures
488f5ea
@luseverin
Correct assert for arrays
4534794
@luseverin
Add pool kwargs in hazard_kwargs
2d15a81
@luseverin
add from hazard as class method
09fd55b
@luseverin
Add docstrings to hazardForecast base class
86c9d93
@luseverin
Rename fixture
33d0ad9
@luseverin
Fix haz_kwargs in test hazards base
dfdecd9
@luseverin
Correct class atr error in from_hazard
5880669
@luseverin
add member leadtime and forecast as fixtures
71339af
@peanutfun
Merge branch 'forecast-class' into hazardForecast_base_class
9aa7e4b
@peanutfun
Automatize Hazard attribute testing
f6d0373
@peanutfun
Update docstrings
ef3551b
@luseverin
Add test for hazardForecast.concat
412fbd8
@luseverin
Merge branch 'forecast-class' into hazardForecast_concat_test
2e00061
@peanutfun peanutfun merged commit d04fecf into forecast-class Dec 8, 2025
4 of 5 checks passed
@emanuel-schmid emanuel-schmid deleted the hazardForecast_concat_test branch December 11, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@peanutfun peanutfun Awaiting requested review from peanutfun peanutfun is a code owner

Assignees

@peanutfun peanutfun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luseverin @peanutfun