add idx boolean selection for member and leadtime#1183
Merged
peanutfun merged 4 commits intoforecast-classfrom Dec 9, 2025
Merged
add idx boolean selection for member and leadtime#1183peanutfun merged 4 commits intoforecast-classfrom
peanutfun merged 4 commits intoforecast-classfrom
Conversation
elianekobler
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
chahank
reviewed
Dec 9, 2025
climada/util/forecast.py
Outdated
| Parameters | ||
| ---------- | ||
| member : np.ndarray | ||
| Forecast ensemble members, given as integers. |
Member
There was a problem hiding this comment.
That is not very clear. How about
Suggested change
| Forecast ensemble members, given as integers. | |
| Index of the forecast members in the forecast.member array. |
chahank
reviewed
Dec 9, 2025
|
|
||
| def test_idx_member(): | ||
| """Test idx_member method of Forecast class.""" | ||
| forecast = Forecast(member=np.array([1, 2, 3, 4])) |
Member
There was a problem hiding this comment.
What happens if I put forecast = Forecast(member=np.array([1, 1, 3, -5, '6'])) ?
Member
There was a problem hiding this comment.
Works completely fine. The isin compares element-wise. Is this really necessary to test here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #1159
PR Author Checklist
develop)PR Reviewer Checklist